Skip to content

Conversation

@fisakov
Copy link
Contributor

@fisakov fisakov commented Oct 20, 2025

A dependency on de.q60.mps.collections.libs solution is re-exported by de.q60.mps.polymorphicfunctions.runtime.
Also, explicitly list library jars in build layout.

A dependency on de.q60.mps.collections.libs solution is re-exported by
de.q60.mps.polymorphicfunctions.runtime.
Also, explicitly list library jars in build layout.
@sergej-koscejev
Copy link
Collaborator

I don't see why the change from 'files from' to individual files is useful, in my view it only adds maintenance burden in case the set of jars changes.

@sergej-koscejev
Copy link
Collaborator

Also, I want to refactor the code tomorrow to avoid exporting this dependency. It's only needed in one place in the generator, we can introduce a method to hide it.

@fisakov
Copy link
Contributor Author

fisakov commented Oct 21, 2025

I don't see why the change from 'files from' to individual files is useful, in my view it only adds maintenance burden in case the set of jars changes.

Disagree. Data in the model is searchable, reliance on external source of data is akin to blind man walk.

@fisakov
Copy link
Contributor Author

fisakov commented Oct 21, 2025

Anyways, this patch makes mps-extension build on our CI. Just FYI.

@sergej-koscejev
Copy link
Collaborator

I don't see why the change from 'files from' to individual files is useful, in my view it only adds maintenance burden in case the set of jars changes.

Disagree. Data in the model is searchable, reliance on external source of data is akin to blind man walk.

This data is derived, the origin of the data is in the Gradle build files (and/or transitive dependency POMs). Adding redundant data to the model that has to be manually updated just so that it becomes searchable is counterproductive.

@fisakov
Copy link
Contributor Author

fisakov commented Oct 21, 2025

Whatever, your house your rules.

@fisakov fisakov closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants